sqlite: set name and length on sqlite.backup()#58251
Merged
nodejs-github-bot merged 1 commit intonodejs:mainfrom May 11, 2025
Merged
sqlite: set name and length on sqlite.backup()#58251nodejs-github-bot merged 1 commit intonodejs:mainfrom
name and length on sqlite.backup()#58251nodejs-github-bot merged 1 commit intonodejs:mainfrom
Conversation
Collaborator
|
Review requested:
|
nodejs-github-bot
added
c++
cjihrig
approved these changes
May 9, 2025
Contributor
cjihrig
left a comment
cjihrig
left a comment
There was a problem hiding this comment.
LGTM with a minor nit. Thanks!
src/node_sqlite.cc
Outdated
| 2).ToLocal(&backup_function)) { | ||
| return; | ||
| } | ||
| backup_function->SetName(FIXED_ONE_BYTE_STRING(isolate, "backup")); |
Contributor
There was a problem hiding this comment.
I think we already have backup_string that can be used here.
LiviaMedeiros
force-pushed
the
sqlite-backup-props
branch
from
1bb0b66 to
cc251a3
Compare
geeksilva97
approved these changes
May 9, 2025
github-actions
bot
removed
the
request-ci
Contributor
Failed to start CI⚠ Commits were pushed since the last approving review: ⚠ - sqlite: set `name` and `length` on `sqlite.backup()` ✘ Refusing to run CI on potentially unsafe PRhttps://github.com/nodejs/node/actions/runs/14933373676 |
github-actions
bot
added
the
request-ci-failed
Collaborator
LiviaMedeiros
removed
the
request-ci-failed
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #58251 +/- ##
==========================================
+ Coverage 90.12% 90.18% +0.05%
==========================================
Files 629 629
Lines 186638 186659 +21
Branches 36618 36654 +36
==========================================
+ Hits 168202 168331 +129
+ Misses 11222 11123 -99
+ Partials 7214 7205 -9
🚀 New features to boost your workflow:
|
benjamingr
approved these changes
May 9, 2025
aduh95
added
author ready
nodejs-github-bot
removed
the
commit-queue
Collaborator
|
Landed in 770be2c |
targos
pushed a commit
that referenced
this pull request
May 16, 2025
PR-URL: #58251 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Jun 10, 2025
PR-URL: #58251 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Edy Silva <edigleyssonsilva@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.